Ar add item updates issue 25 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arandel1
requested review from
EmmaBin,
MarcosPerez16,
mentalcaries,
mindyzwan,
nathanejbrown and
sar-mko
|
Visit the preview URL for this PR (updated for commit 6f9e88f): https://tcl-76-smart-shopping-list--pr52-ar-add-item-updates-cue1fmoi.web.app (expires Thu, 10 Oct 2024 03:05:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
EmmaBin
approved these changes
Oct 2, 2024
sar-mko
reviewed
Oct 2, 2024
src/views/Home.jsx
Outdated
| } | ||
| }; | ||
|
|
||
| const shareListNavigate = (e) => { |
There was a problem hiding this comment.
note (non-blocking): I don't think shareListNavigate() is needed anymore since the navigation is handled in ShareListComponent
src/views/Home.jsx
Outdated
| import { useVoiceToText } from '../utils'; | ||
| import DeleteIcon from '@mui/icons-material/Delete'; | ||
| import KeyboardVoiceIcon from '@mui/icons-material/KeyboardVoice'; | ||
| import ShareIcon from '@mui/icons-material/Share'; |
There was a problem hiding this comment.
nitpick ( non-blocking): little clean up can get rid of the ShareIcon import
MarcosPerez16
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
Deletewording to delete iconShare listwording to share iconStart Voice Inputto microphone iconRelated
closes #45
Acceptance Criteria
Type of Changes
enhancementfeature updateUpdates
Before
After
<img width="683" alt="Screen Shot 2024-10-02 at 1 36 45 PM" src="https://github.com/user-attachments/assets/d3170bd6-f064-46e9-8292-9
02b4210c2ba">
Testing Steps / QA Criteria
ar-add-item-updates-issue-25