Skip to content

Conversation

3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Mar 21, 2025

This PR is a cherry-pick of taichi/vscode-textlint#72.

.textlintignore support has broken at 8ee34bc because TextLintEngine.executeOnText() does not consider ignore file. The same goes for linter.lintText(), which was added later.

This pull request will fix .textlintignore support using linter.scanFilePath() API which was added in textlint v14.1.0. If user's textlint version is lower than v14.1.0, .textlintignore is simply ignored and other features works fine.

@3w36zj6 3w36zj6 added the Type: Bug Bug or Bug fixes label Mar 22, 2025
@3w36zj6
Copy link
Member Author

3w36zj6 commented Mar 23, 2025

I've confirmed that .textlintignore is respected in textlint@14 environments, while it's ignored in textlint@13 environments.
Could you please review this? @azu

@azu
Copy link
Member

azu commented Mar 23, 2025

Copy link
Member

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3w36zj6 3w36zj6 merged commit 73a6c99 into main Mar 23, 2025
3 checks passed
@3w36zj6 3w36zj6 deleted the feature/fix-textlintignore-support branch March 23, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Bug or Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants