chore(release): note breaking changes for v5 #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `render` is now more strict about the `target` option, and the `container` result is now the direct parent of your component instance.
Collaborator
Author
|
@yanick looks like we just had another release go out on |
Collaborator
|
Yup, I am on this very page and was about to say "let's merge this, and get v5 out of the door". So, uh, let's merge this, and get v5 out of the door. :-) |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8d98aa5 landed in
nextwith two issues that I didn't realize when I was writing my commit message:semantic-releaseuses the angular commit spec rather than the conventional commit spec, which means it did not recognize the exclamation mark infix!: ...as a breaking changeBREAKING CHANGES:rather thanBREAKING CHANGE:in the commit bodyThis means that the breaking changes in #325 were released improperly as
v4.2.2instead ofv5.0.0on thenextdist tag. This PR adds an empty commit with the correctBREAKING CHANGEmessage below to hopefully trigger a major bump. I'm leaving this as a draft in case there are other breaking changes that should be incorporated in the v5 release.BREAKING CHANGE:
renderis now more strict about thetargetoption, and thecontainerresult is now the direct parent of your component instance.