-
Notifications
You must be signed in to change notification settings - Fork 33
fix: added module path for types to the exports map
#228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
exports maptypes to the exports map
|
Additionally, I'm pretty sure this import path: https://github.com/testing-library/svelte-testing-library/blob/a7ad7fd969f2dc0d0cc70bb81539991a8c77f327/types/index.d.ts#L6-L6C71 should be I can add it to this PR if that's alright. |
|
Yes, please add it!
…On Sun, 25 Jun 2023, at 3:58 PM, CokaKoala wrote:
Additionally, I'm pretty sure this import path: https://github.com/testing-library/svelte-testing-library/blob/a7ad7fd969f2dc0d0cc70bb81539991a8c77f327/types/index.d.ts#L6-L6C71 should be `'svelte'` rather than `'svelte/types/runtime'`. I mention this because this is no longer a valid path in Svelte 4. Importing directly from the `'svelte'` path is supported in both version.
I can add it to this PR if that's alright.
—
Reply to this email directly, view it on GitHub <#228 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE34WW2KRPZXO4EWVSDGLXNA7XLANCNFSM6AAAAAAZTFERMM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
@yanick Done 👍 |
|
Merged, thanks! |
|
How frequently do you cut releases? My CI is currently failing because of a malformed |
|
I just need to have a pr with the right keyword. Will try to do that later on today if i can |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The
exportsmap inpackage.jsonwas missing it'stypesmodule path, causing the import of@testing-library/svelteto throw a type error whenever users had"moduleResolution": "nodenext"set in theirtsconfig.json.