[test] Fix npm run validate
#1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
sebbie/11-05-_test_fix_npm_run_typecheck_
branch
from
2bf4934 to
e6b98aa
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6b98aa:
|
eps1lon
commented
Nov 5, 2025
Comment on lines
+14
to
+16
| "build:bundle:main": "dotenv -e .bundle.main.env kcd-scripts build -- --bundle --no-clean --no-ts-defs", | ||
| "build:bundle:pure": "dotenv -e .bundle.main.env -e .bundle.pure.env kcd-scripts build -- --bundle --no-clean --no-ts-defs", | ||
| "build:main": "kcd-scripts build --no-clean --no-ts-defs", |
There was a problem hiding this comment.
Also perf build optimization. We're not using generated declaration files but manually write ours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kcd-scriptsmay use a different version of TypeScript since it resolves relative tokcd-scriptsnot the caller. It also uses--buildwhich we're not using. Switching to basictscwhich makes it easier to reason about what is being used.Fixes
-- https://github.com/testing-library/react-testing-library/actions/runs/19101381490/job/54573962927?pr=1214