Skip to content

feat: add warnings when globals are missing #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2023
+8 −0
Merged

feat: add warnings when globals are missing #1244

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95082d7
chore: add warnings when globals are missing
MatanBobi Oct 13, 2023
71ccd51
Merge branch 'main' into chores/add-warnings-when-missing-globals
MatanBobi Oct 13, 2023
6440a4a
revert the istanbul ignore removal
MatanBobi Oct 24, 2023
6dae7e6
improve error message
MatanBobi Oct 24, 2023
39fdc6c
Apply suggestions from code review
MatanBobi Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ if (typeof process === 'undefined' || !process.env?.RTL_SKIP_AUTO_CLEANUP) {
teardown(() => {
cleanup()
})
} else {
console.warn(
`The current test runner does not support afterEach/teardown. This means we won't be able to run automatic cleanup and you should be calling cleanup() manually.`,
)
}

// No test setup with other test runners available
Expand All @@ -35,6 +39,10 @@ if (typeof process === 'undefined' || !process.env?.RTL_SKIP_AUTO_CLEANUP) {
afterAll(() => {
setReactActEnvironment(previousIsReactActEnvironment)
})
} else {
console.warn(
'The current test runner does not support beforeAll/afterAll. This means you should be setting IS_REACT_ACT_ENVIRONMENT manually.',
)
}
}

Expand Down