Skip to content

fix: ReactHooksRenderer renderHook was not expecting arguments #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021
Merged

fix: ReactHooksRenderer renderHook was not expecting arguments #526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb870e0
fix: ReactHooksRenderer renderHook was not expecting arguments
joshuaellis Jan 7, 2021
9bab184
change: move RenderHookOptions into types/index
joshuaellis Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { RenderHookOptions } from './internal'

export type Renderer<TProps> = {
render: (props?: TProps) => void
rerender: (props?: TProps) => void
Expand Down Expand Up @@ -48,7 +50,10 @@ export type RenderHook<
AsyncUtils

export interface ReactHooksRenderer {
renderHook: <TProps, TResult>() => RenderHook<TProps, TResult>
renderHook: <TProps, TResult, TOptions>(
callback: (props: TProps) => TResult,
options?: RenderHookOptions<TProps, TOptions>
) => RenderHook<TProps, TResult>
act: Act
cleanup: () => void
addCleanup: (callback: () => Promise<void> | void) => () => void
Expand Down