Skip to content

chore: remove eslint-config-kentcdodds #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2024
Merged

chore: remove eslint-config-kentcdodds #856

merged 3 commits into from
Jan 12, 2024

Conversation

@lesha1201
Copy link
Contributor

@lesha1201 lesha1201 commented Dec 12, 2023

Checks

Context

These changes were initially introduced in #852

@lesha1201
chore: remove eslint-config-kentcdodds
bb928e6 
`eslint-config-kentcdodds` uses some outdated packages which block
us from upgrading TypeScript dependencies.
@Belco90 Belco90 self-requested a review December 13, 2023 12:29
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Dec 13, 2023
Belco90
Belco90 requested changes Dec 13, 2023
View reviewed changes
@lesha1201 lesha1201 requested a review from Belco90 December 14, 2023 07:20
@lesha1201
Copy link
Contributor Author

lesha1201 commented Dec 14, 2023

@Belco90 By the way, do you have some conventions/rules in mind that you want to enforce? I would like to improve ESLint setup later but not very familiar with the codebase yet and its conventions.

This was referenced Dec 14, 2023
Closed
Merged
@Belco90
Copy link
Member

Belco90 commented Jan 12, 2024

@Belco90 By the way, do you have some conventions/rules in mind that you want to enforce? I would like to improve ESLint setup later but not very familiar with the codebase yet and its conventions.

I have something in mind, but let's do that in a follow-up PR.

Belco90
Belco90 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response! The Christmas break was way busier than I thought, so I'm slowly coming back to this now.

@Belco90 Belco90 merged commit 4771896 into testing-library:main Jan 12, 2024
@Belco90
Copy link
Member

Belco90 commented Jan 12, 2024

@all-contributors please add @lesha1201 for maintenance

@allcontributors allcontributors bot mentioned this pull request Jan 12, 2024
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jan 12, 2024

@Belco90

I've put up a pull request to add @lesha1201! 🎉

@github-actions
Copy link

github-actions bot commented Apr 12, 2024

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

@lesha1201 lesha1201

Labels

chore Changes that affect the build system, CI config or other changes that don't modify src/test files released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesha1201 @Belco90