Skip to content

fix: use defineProperty on the error object instead of setting the message directly #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: use defineProperty on the error object instead of setting the message directly #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/__tests__/wait-for.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,31 @@ test('timeout logs a pretty DOM', async () => {
`)
})

test("timeout doesn't error on DOMExceptions", async () => {
renderIntoDocument(`<div id="pretty">how pretty</div>`)
const error = await waitFor(
() => {
throw new DOMException('nooooooo!')
},
{timeout: 1},
).catch(e => e)
expect(error.message).toMatchInlineSnapshot(`
nooooooo!

Ignored nodes: comments, script, style
<html>
<head />
<body>
<div
id="pretty"
>
how pretty
</div>
</body>
</html>
`)
})

test('should delegate to config.getElementError', async () => {
const elementError = new Error('Custom element error')
const getElementError = jest.fn().mockImplementation(() => elementError)
Expand Down
7 changes: 3 additions & 4 deletions src/wait-for.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ function waitFor(
stackTraceError,
interval = 50,
onTimeout = error => {
error.message = getConfig().getElementError(
error.message,
container,
).message
Object.defineProperty(error, 'message', {
value: getConfig().getElementError(error.message, container).message,
})
return error
},
mutationObserverOptions = {
Expand Down