Skip to content

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Nov 10, 2020

Reverts #4186.

Nightly builds fail after the CI refactor due to N-API version mismatches. I thought I had tested a nightly build with NIGHTLY=true gcloud builds submit . --config=cloudbuild_generated.yml, but I actually have to change the _NIGHTLY variable in the generated cloudbuild file to true. I'll investigate and fix this and then create a new PR with this PR's changes plus the fix.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@mattsoulanille mattsoulanille deleted the revert-4186-generate_cloud_build branch December 14, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant