Update usage of numpy to reflect numpy 2.0 changes #6871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@JamesHollyer Hello! When can I expect this change to show up in the stable python package? |
|
Hi there, glad to see this fix went in! Are you all planning a release for this fix to take effect more widely? Thanks very much for your support! |
groszewn
pushed a commit
to groszewn/tensorboard
that referenced
this pull request
Aug 13, 2024
## Motivation for features / changes Nightlies are failing due to new numpy release(one example: https://github.com/tensorflow/tensorboard/actions/runs/9546526095/job/26309613783) ## Technical description of changes The new numpy replaced np.string_ with np.bytes_ and np.unicode_ with np.str_ ## Screenshots of UI changes (or N/A) ## Detailed steps to verify changes work correctly (as executed by you) I ran tests that were failing and they passed. ## Alternate designs / implementations considered (or N/A) Locking numpy version < 2 was considered. However, this will eventually get us very out of date and should be avoided. --------- Co-authored-by: James Hollyer <[email protected]>
groszewn
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Motivation for features / changes Nightlies are failing due to new numpy release(one example: https://github.com/tensorflow/tensorboard/actions/runs/9546526095/job/26309613783) ## Technical description of changes The new numpy replaced np.string_ with np.bytes_ and np.unicode_ with np.str_ ## Screenshots of UI changes (or N/A) ## Detailed steps to verify changes work correctly (as executed by you) I ran tests that were failing and they passed. ## Alternate designs / implementations considered (or N/A) Locking numpy version < 2 was considered. However, this will eventually get us very out of date and should be avoided. --------- Co-authored-by: James Hollyer <[email protected]>
j3soon
added a commit
to j3soon/tbparse
that referenced
this pull request
Aug 13, 2024
This is a temporary requirement and should be removed after the tensorboard 2.17.1 release. References: - tensorflow/tensorboard#6871 - tensorflow/tensorboard#6874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Nightlies are failing due to new numpy release(one example: https://github.com/tensorflow/tensorboard/actions/runs/9546526095/job/26309613783)
See #6869 for context.
Technical description of changes
The new numpy replaced np.string_ with np.bytes_ and np.unicode_ with np.str_
Screenshots of UI changes (or N/A)
Detailed steps to verify changes work correctly (as executed by you)
I ran tests that were failing and they passed.
Alternate designs / implementations considered (or N/A)
Locking numpy version < 2 was considered. However, this will eventually get us very out of date and should be avoided.