Skip to content

fix: text overflow in CosmosTextButton #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

fix: text overflow in CosmosTextButton #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/cosmos_ui_components/lib/components/cosmos_text_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ class CosmosTextButton extends StatelessWidget {
this.textStyle,
this.iconTopSpacing,
this.color,
this.maxLines = 1,
this.overflow = TextOverflow.ellipsis,
}) : super(key: key);

static const defaultHeight = 50.0;
Expand All @@ -26,6 +28,8 @@ class CosmosTextButton extends StatelessWidget {
final TextStyle? textStyle;
final Color? color;
final double? iconTopSpacing;
final int maxLines;
final TextOverflow overflow;

@override
Widget build(BuildContext context) {
Expand All @@ -48,10 +52,9 @@ class CosmosTextButton extends StatelessWidget {
],
Text(
text,
style: textStyle ??
CosmosTextTheme.elevatedButton.copyWith(
color: color,
),
maxLines: maxLines,
overflow: overflow,
style: textStyle ?? CosmosTextTheme.elevatedButton.copyWith(color: color),
),
if (suffixIcon != null) ...[
if (text.isNotEmpty) SizedBox(width: CosmosTheme.of(context).spacingS),
Expand All @@ -74,6 +77,8 @@ class CosmosTextButton extends StatelessWidget {
..add(ColorProperty('color', color))
..add(StringProperty('text', text))
..add(DiagnosticsProperty<TextStyle?>('textStyle', textStyle))
..add(DoubleProperty('height', height));
..add(DoubleProperty('height', height))
..add(IntProperty('maxLines', maxLines))
..add(EnumProperty<TextOverflow>('overflow', overflow));
}
}