refactor: Extract AppVersionText into a separate widget + Add a new widget = ChipText
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wal33d006
changed the title
AppVersionInfo into a separate widgetAppVersionText into a separate widget
wal33d006
changed the title
AppVersionText into a separate widgetAppVersionText into a separate widget + Add a new widget = ChipText
Zfinix
approved these changes
Apr 5, 2022
andrzejchm
suggested changes
Apr 5, 2022
Contributor
andrzejchm
left a comment
andrzejchm
left a comment
There was a problem hiding this comment.
looks great! lets just add some optional styling capabilities to the widgets
| import 'package:flutter/material.dart'; | ||
|
|
||
| class AppVersionText extends StatelessWidget { | ||
| const AppVersionText({required this.appInfoProvider, Key? key}) : super(key: key); |
Contributor
There was a problem hiding this comment.
Suggested change
| const AppVersionText({required this.appInfoProvider, Key? key}) : super(key: key); | |
| const AppVersionText({required this.appInfoProvider, Key? key,}) : super(key: key); |
| final AppInfoProvider appInfoProvider; | ||
|
|
||
| @override | ||
| void debugFillProperties(DiagnosticPropertiesBuilder properties) { |
Contributor
There was a problem hiding this comment.
this method should be at the bottom of the class
| @override | ||
| Widget build(BuildContext context) => FutureBuilder<String>( | ||
| future: appInfoProvider.getAppVersion(), | ||
| builder: (context, snapshot) => Text(snapshot.data ?? ''), |
Contributor
There was a problem hiding this comment.
right now we're not able to style it, let's add another optional TextStyle? to the constructor of AppVersionText and pass it into this Text widget
| padding: EdgeInsets.all(theme.spacingM), | ||
| decoration: BoxDecoration( | ||
| borderRadius: BorderRadius.circular(10), | ||
| color: theme.colors.chipBackground, |
Contributor
There was a problem hiding this comment.
let's make the Color? color an optional parameter to the ChipText widget with the default value of theme.colors.chipBackground
| borderRadius: BorderRadius.circular(10), | ||
| color: theme.colors.chipBackground, | ||
| ), | ||
| child: Text(title), |
Contributor
There was a problem hiding this comment.
let's add optional parameter of TextStyle? to the ChipText constructor and pass it to this Text widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.