Skip to content

Conversation

@chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Oct 23, 2025

What was changed

TSIA

Other small changes:

  • renamed task queues for plugin tests so we don't hit the new namespace+client+task_queue uniqueness requirement
  • disabled heartbeat by default. Will enable things in a separate PR, once configuring this is plumbed through TS.

Why?

With the code moving, updating core is more involved than usual. Doing this in a separate PR to make it easier to review.

Checklist

  1. Closes N/A

  2. How was this tested:
    Existing tests

  3. Any docs updates needed?
    I do not believe so

@chris-olszewski chris-olszewski force-pushed the olszewski/update_core branch 2 times, most recently from ab40243 to cb60d7c Compare October 23, 2025 18:31
@chris-olszewski chris-olszewski marked this pull request as ready for review October 23, 2025 20:05
@chris-olszewski chris-olszewski requested a review from a team as a code owner October 23, 2025 20:05
Copy link
Contributor

@yuandrew yuandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a worker heartbeating POV, deferring to James for overall approval

@yuandrew
Copy link
Contributor

My mistake, i messed up my git while trying to work on my new branch after branching off of your branch 😅

@yuandrew yuandrew marked this pull request as ready for review November 10, 2025 21:34
@mjameswh mjameswh self-requested a review November 12, 2025 23:19
@chris-olszewski chris-olszewski merged commit d919b22 into main Nov 13, 2025
48 of 52 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/update_core branch November 13, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants