fix(view): handle boolean attribute followed by non space whitespace or self-closing tags #1632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered compilation issues with else control structure :
While debugging this I found that the lexer consumes more characters than expected in the ATTRIBUTE_NAME token when handling boolean attributes followed by a self-closing tag or a non space whitespace.
My fix is correct HTML-wise as far I as know but I've never worked on a lexer before and may not have thought about a possible regression.
One existing test failed, but the expected case was inconsistent with the others attributes. I updated it and all other view tests passed.