Skip to content

Conversation

frco9
Copy link
Contributor

@frco9 frco9 commented Aug 11, 2025

On a GHES instance, I had the following error when using the action :

Error: Error checking PR comments: Bad credentials - https://docs.github.com/rest

I've tried to also pass a PAT, and error was the same.

As per Github documentation it seems for most cases we should use Bearer instead of token for auth param.
Capture d’écran 2025-08-11 à 19 15 49

With this fix I don't have auth error anymore.

@frco9 frco9 requested a review from virgofx as a code owner August 11, 2025 17:24
@virgofx
Copy link
Member

virgofx commented Aug 13, 2025

Thanks @frco9 - Let me test a couple things here to make sure this works.

Copy link
Member

@virgofx virgofx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's just remove the /dist updates here (as the workflow does that automatically)

@frco9 frco9 force-pushed the fix/use_bearer_auth branch from e784259 to f0f0a0e Compare August 13, 2025 16:26
@frco9
Copy link
Contributor Author

frco9 commented Aug 13, 2025

Thanks for review @virgofx. I've updated the PR.

@virgofx virgofx merged commit 0dc9ec5 into techpivot:main Aug 17, 2025
4 of 6 checks passed
@virgofx
Copy link
Member

virgofx commented Aug 17, 2025

Thanks @frco9 - I'm going to test one more thing then cut a release (hopefully Monday/Tuesday)

@release-preview release-preview bot mentioned this pull request Aug 21, 2025
@virgofx
Copy link
Member

virgofx commented Aug 21, 2025

hi @frco9 - I have a pre-release out v1.7.0 that contains the fix here. If you're able to explicitly reference this version, test, and confirm working, that would be great! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants