Update xkcdViewer provider to use HTTPS URLs #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkcd.com changed to using HTTPS some time ago; the change causes XkcdViewer to fail with "Data returned from website didn't match expected format" as the 301 redirect is attempted to be parsed as JSON, which obviously fails. While this isn't a complete fix, it should hopefully fix the app enough for it to work again. Fixes tcoxon#70.
|
When I say this isn't a complete fix, I mean that really, the app should be following redirects instead of trying to parse the empty redirect response as JSON. That's for someone to do who actually has the correct build environment, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xkcd.com changed to using HTTPS some time ago; the change causes XkcdViewer to fail with "Data returned from website didn't match expected format" as the 301 redirect is attempted to be parsed as JSON, which obviously fails.
While this isn't a complete fix, it should hopefully fix the app enough for it to work again.
Fixes #70.
(Please note that I have not been able to test this as I do not have the correct build environment. I believe that my changes are correct, however!)