Add test case when countBytes in TA.p.slice is set to zero #4537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`countBytes` can be set to zero in step 14.d when resizable array buffers are used.
|
This case isn't covered by existing tests. |
gibson042
requested changes
Jul 16, 2025
| var sliced = ta.slice(start); | ||
|
|
||
| // Result typed array has the correct length with all elements set to zero. | ||
| assert.compareArray(sliced, new TA(N - startIndex)); |
There was a problem hiding this comment.
Suggested change
| assert.compareArray(sliced, new TA(N - startIndex)); | |
| assert.compareArray(sliced, new TA(N - startIndex), TA.name + ", start index " + startIndex); |
| var ta = new SourceTA(buffer); | ||
|
|
||
| // Create own "constructor" property to create a different result typed array. | ||
| ta.constructor = TargetTA; |
There was a problem hiding this comment.
For not breaking in a hardened environment:
Suggested change
| ta.constructor = TargetTA; | |
| Object.defineProperty(ta, "constructor", { value: TargetTA }); |
Comment on lines
+77
to
+78
| // Result typed array has the correct length with all elements set to zero. | ||
| assert.compareArray(sliced, new TargetTA(N - startIndex)); |
There was a problem hiding this comment.
Suggested change
| // Result typed array has the correct length with all elements set to zero. | |
| assert.compareArray(sliced, new TargetTA(N - startIndex)); | |
| // Result typed array has the correct type and length with all elements set to zero. | |
| var label = SourceTA.name + " to " + TargetTA.name; | |
| assert.sameValue(sliced.constructor, TargetTA, label); | |
| assert.compareArray(sliced, new TargetTA(N - startIndex), | |
| label + ", start index " + startIndex); |
|
@anba would you mind addressing the comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
countBytescan be set to zero in step 14.d when resizable array buffers are used.