Skip to content

feat: support table-valued function in tsql #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: support table-valued function in tsql #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pegjs/transactsql.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,6 +1814,9 @@ table_base
type: 'dual'
};
}
/ e:func_call __ alias:alias_clause? {
return { type: 'expr', expr: e, as: alias };
}
/ t:table_name __ tt:temporal_table? __ alias:alias_clause? __ th:table_hint? {
t.as = alias
t.table_hint = th
Expand Down
3 changes: 2 additions & 1 deletion src/column.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ function columnRefToSQL(expr) {
function columnDataType(definition) {
if (!definition) return
const { dataType, length, suffix, scale, expr } = definition
let result = dataTypeToSQL({ dataType, length, suffix, scale, parentheses: length != null ? true : false })
const parentheses = length != null && true || false
let result = dataTypeToSQL({ dataType, length, suffix, scale, parentheses })
if (expr) result += exprToSQL(expr)
if (definition.array) {
const arrayExpr = arrayDimensionToSymbol(definition)
Expand Down
7 changes: 7 additions & 0 deletions test/transactsql.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,13 @@ describe('transactsql', () => {
'CREATE TABLE [visits] ([url] VARBINARY(max))'
]
},
{
title: 'table-valued function in from clause',
sql: [
"select * from dbo.fn_name(N'000')",
"SELECT * FROM dbo.fn_name(N'000')"
]
},
]
SQL_LIST.forEach(sqlInfo => {
const { title, sql } = sqlInfo
Expand Down