Skip to content

Conversation

@rherilier
Copy link
Contributor

  • one about a block statement that clang-format want to erroneously wrap with an empty one;
  • one about an extra space.

rherilier and others added 3 commits September 29, 2024 12:31
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

I just checked the current clang format errors in the CI and your PR look really good to be merged and fix those errors.

@codecov
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (821c7d8) to head (f18dde2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         257      257           
  Lines        9191     9191           
  Branches      804      804           
=======================================
  Hits         6803     6803           
  Misses       1785     1785           
  Partials      603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uilianries uilianries merged commit 3d1d4fc into taocpp:main Dec 29, 2024
57 checks passed
@rherilier rherilier deleted the fix-clang-format-reports branch December 29, 2024 13:39
@rherilier
Copy link
Contributor Author

you're welcome

merry end of the year ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants