Ensure not-* does not remove :is(…)
#16825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/not-open
branch
from
01870f9 to
581480f
Compare
RobinMalfait
approved these changes
Feb 26, 2025
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Another option is to check whether this was used in another forgiving wrapper or not.
But I think that's an optimization that can be added later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16821
This PR removes a special case in the
not-*variant compound that removed:is(…)if it was the only part of the inversed selector list. While in-theory this makes sense,:is(…)accepts a forgiving selector list where as:not(…)does not. See the last point here.This is an issue specifically in combinations with variants that have selectors that are not supported by all browsers yet, for example
:open.It seems to be the most expected to simply keep the
:is(…)here in any case.Test plan
not-openis generated but not applied #16821 now also works in browsers that do not support:open(Safari and Firefox at the time of writing this):