fix(cloudwatch-metrics-stream): fix optional variables #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the configuration and documentation for the CloudWatch metrics stream integration, focusing on clarifying when certain variables are required and enhancing validation logic. The changes ensure that variables related to role creation and authentication are only required when appropriate, and provide better error messages and documentation for users.
Variable validation improvements:
sysdig_aws_account_id
andsysdig_external_id
variables in bothmodules/cloud-watch-metrics-stream/variables.tf
andexamples/cloudwatch-metrics-stream-single-account/variables.tf
to only require values whencreate_new_role
istrue
, with improved validation and error messages.secret_key
variable to ensure that bothsecret_key
andaccess_key_id
are either set together or both left empty, preventing misconfiguration.secret_key
andaccess_key_id
variables for clarity.Resource adjustments:
main.tf
to usesecret_key
andaccess_key_id
to determine whichsysdig_monitor_cloud_account
resource to create, rather than relying oncreate_new_role
.iam.tf
to use the correct role name depending on whether a new role is being created.