[TwigComponent] Remove obsolete TemplateNameParser #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer parses (and should not have been stripping namespaces as it did before)
Kocal
changed the title
smnandre
approved these changes
Jan 18, 2025
Member
smnandre
left a comment
smnandre
left a comment
There was a problem hiding this comment.
As discussed on Slack, i'm very happy to not have to digg again in here :)
And i'm glad we did not do something that created BC.
So everything perfect :)
carsonbot
added
Status: Reviewed
Member
|
Thank you @sneakyvv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It no longer parses (and should not have been stripping namespaces as it did before)
As discussed in #1772 (comment), the code added in #1070 (& expanded in #1082) was not needed (even incorrect, based upon a decorator TemplateIterator of Shopware).