Skip to content

[JsonPath] Add test documentation for the component #21090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

[JsonPath] Add test documentation for the component #21090

merged 1 commit into from
Jun 19, 2025

Conversation

@vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Jun 17, 2025

Updates the documentation to document JsonPathAssertionsTrait and related constraints (closes #20977).

Complete the previous work done in #21078.

@vinceAmstoutz vinceAmstoutz mentioned this pull request Jun 17, 2025
Closed
@vinceAmstoutz vinceAmstoutz changed the title docs(json-path): add testing part doc for the component [JsonPath] Add test documentation for the component Jun 17, 2025
@vinceAmstoutz vinceAmstoutz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from e4e14e1 to b1c2340 Compare June 17, 2025 08:51
OskarStark
OskarStark reviewed Jun 17, 2025
View reviewed changes
@vinceAmstoutz vinceAmstoutz requested a review from OskarStark June 17, 2025 09:32
javiereguiluz
javiereguiluz approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Vincent! Thanks.

@carsonbot carsonbot changed the title [JsonPath] Add test documentation for the component Add test documentation for the component Jun 18, 2025
@carsonbot carsonbot changed the title Add test documentation for the component [JsonPath] Add test documentation for the component Jun 18, 2025
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Jun 19, 2025

@alamirault a composer require phpunit/phpunit --dev is it necessary to correct this CI work? I can make a PR if necessary.

alexandre-daubois
alexandre-daubois reviewed Jun 19, 2025
View reviewed changes
@vinceAmstoutz vinceAmstoutz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from 85bc74a to 8d20ebb Compare June 19, 2025 09:26
@OskarStark
Copy link
Contributor

OskarStark commented Jun 19, 2025

@alamirault a composer require phpunit/phpunit --dev is it necessary to correct this CI work? I can make a PR if necessary.

Might be a good idea, @symfony/docs WDYT?

@vinceAmstoutz vinceAmstoutz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from 8d20ebb to f03d8e2 Compare June 19, 2025 10:05
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Jun 19, 2025

Rebased from 7.3 ✅

alexandre-daubois
alexandre-daubois reviewed Jun 19, 2025
View reviewed changes
Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to wrap your lines at 80 chars overall 🙂

@OskarStark
Copy link
Contributor

OskarStark commented Jun 19, 2025

~80 chars 😄 not a hard limit, but an orientation

@vinceAmstoutz vinceAmstoutz mentioned this pull request Jun 19, 2025
Merged
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Jun 19, 2025

@alexandre-daubois Done for 80 👍

@vinceAmstoutz vinceAmstoutz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from ad3f520 to b5c9c0a Compare June 19, 2025 13:29
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Jun 19, 2025 •
edited
Loading

But for lisst when I rendenring them it's look like :/ @alexandre-daubois @OskarStark
image

@alexandre-daubois
Copy link
Member

alexandre-daubois commented Jun 19, 2025

Try indenting with the rest, i.e. two spaces for each line under the list item

alexandre-daubois
alexandre-daubois reviewed Jun 19, 2025
View reviewed changes
@vinceAmstoutz vinceAmstoutz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from b5c9c0a to 24429d5 Compare June 19, 2025 13:57
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Jun 19, 2025

Try indenting with the rest, i.e. two spaces for each line under the list item

Done everywhere, its works as expected! 👍

alexandre-daubois
alexandre-daubois reviewed Jun 19, 2025
View reviewed changes
@javiereguiluz javiereguiluz force-pushed the docs/json-path/add-assertions-and-trait-the-component-doc branch from 24429d5 to 87ccbb5 Compare June 19, 2025 14:21
@javiereguiluz javiereguiluz merged commit 481cb7a into symfony:7.3 Jun 19, 2025
2 of 3 checks passed
@javiereguiluz
Copy link
Member

javiereguiluz commented Jun 19, 2025

Merged! Thanks a lot Vincent for your recent contributions to Symfony Docs!

@vinceAmstoutz vinceAmstoutz deleted the docs/json-path/add-assertions-and-trait-the-component-doc branch June 19, 2025 21:33
alexandre-daubois added a commit to symfony-tools/symfony-application that referenced this pull request Sep 19, 2025
@alexandre-daubois
minor #37 Add phpunit in dev deps and updates recipes (vinceAmstoutz)
0e11aae 
This PR was merged into the 7.3 branch.

Discussion
----------

Add phpunit in dev deps and updates recipes

Following symfony/symfony-docs#21090 (comment) and symfony/symfony-docs#21090 (comment)

Commits
-------

7d8751e Add phpunit/phpunit and updates recipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

1 more reviewer

@alexandre-daubois alexandre-daubois alexandre-daubois left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

JsonPath Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JsonPath] Add JsonPathAssertionsTrait and related constraints

5 participants

@vinceAmstoutz @OskarStark @alexandre-daubois @javiereguiluz @carsonbot