Skip to content

run composer validate before installing dependencies #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

run composer validate before installing dependencies #1571

merged 1 commit into from
May 21, 2025

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented May 20, 2025 •
edited
Loading

in #1540 it was forgotten to sync the composer.lock file

@xabbuh xabbuh mentioned this pull request May 20, 2025
Merged
rosier
rosier reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@rosier rosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also remove the following lines: https://github.com/symfony/demo/pull/1571/files#diff-4b122024a3a28ded65da76a2f1bface1f3a27328374438d1298d25585fe0603bR77-R80

@rosier
Copy link
Contributor

rosier commented May 20, 2025

Moving up the composer validate check makes sense since the current check is to late to detect the problem described in #1570

@xabbuh xabbuh changed the title run composer validate with GitHub Actions run composer validate before installing dependencies May 21, 2025
@xabbuh xabbuh merged commit e49b81c into symfony:main May 21, 2025
7 of 8 checks passed
@xabbuh xabbuh deleted the pr-1540 branch May 21, 2025 06:55
xabbuh added a commit that referenced this pull request May 21, 2025
@xabbuh
minor #1572 install security patches (xabbuh)
16e7e5a 
This PR was merged into the main branch.

Discussion
----------

install security patches

based on #1571

Commits
-------

c8d2daa install security patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

@mtarld mtarld mtarld approved these changes

+1 more reviewer

@rosier rosier rosier left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh @rosier @stof @mtarld