Remove MessageBagInterface #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
remove-message-bag-interface
branch
from
32f2e2a to
b09299e
Compare
chr-hertel
force-pushed
the
remove-message-bag-interface
branch
from
b09299e to
d181fbe
Compare
OskarStark
approved these changes
Aug 25, 2025
Contributor
|
Thank you @chr-hertel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MessageBag was final for some time and the interface was needed to bring in more capabilities that users want to have on their end. The interface was quite heavy tho and changes would also be quite impactful - not saying adding a method to a class that gets extended is fun, but still less annoying from maintenance point of view - i hope 😬