Skip to content

Conversation

@wouterj
Copy link
Contributor

@wouterj wouterj commented Jul 31, 2024

@javiereguiluz after seeing my changes online, I discovered 2 minor bugs that are fixed with this PR:

  • Highlight public/protected/private when using constructor property promotion
  • Fix highlighting attribute arguments (these were now parsed as function definition parameters instead of invocation arguments, e.g. lacking named argument support)

@javiereguiluz
Copy link
Collaborator

This is great! Wouter, you keep improving highlighting more and more 🙌 Thanks 🙇

@javiereguiluz javiereguiluz merged commit 6702f0d into symfony-tools:main Aug 2, 2024
@wouterj wouterj deleted the php-highlighting-fixes branch August 2, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants