Demo: Use GLCanvas for SkijaGC to render button #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
Snippet24 didn't compile.
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
That way it will be rendered in Linux (as a black square so it still doesn't really work)
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
If you want to use it change super class of `Text` from `CText` to `CSimpleText`.
All 3 classes were copy-pasted from this article: https://www.eclipse.org/articles/Article-Writing%20Your%20Own%20Widget/Writing%20Your%20Own%20Widget.htm Only the absolutely necessary changes were made so the code compiles.
On MacOS, it still uses the own rendering by inheriting from `CCaret`
Signed-off-by: Denis Ungemach <[email protected]>
Signed-off-by: Denis Ungemach <[email protected]>
The implementation is missing though.
Its implementation is empty
HeikoKlare
force-pushed
the
button-use-glcanvas
branch
from
ad1efbb to
9f4e525
Compare
Signed-off-by: Denis Ungemach <[email protected]>
This reverts commit 8d6e071.
HeikoKlare
force-pushed
the
button-use-glcanvas
branch
from
9f4e525 to
c608fa9
Compare
fedejeanne
force-pushed
the
skija
branch
2 times, most recently
from
659fde0 to
75c432c
Compare
HeikoKlare
force-pushed
the
master
branch
4 times, most recently
from
a9f24e5 to
d2109d6
Compare
tmssngr
force-pushed
the
master
branch
2 times, most recently
from
3d97fac to
aa02556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently for demonstration purpose and not to be merged.
With this change, the
SkijaGCis extended by the capability of rendering directly into the buffer of aGLCanvas, and this functionality is applied to theButton.This change drastically improves performance as the bad-performing copy operation between Skia buffer and native buffer is avoided. Initial performance tests show a severe speedup of > 100 (i.e. 10.000%).