Fix wrong fix-it in modifier for variable decl #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
commented
May 8, 2023
kimdv
commented
May 8, 2023
kimdv
commented
May 8, 2023
ahoppen
reviewed
May 8, 2023
kimdv
force-pushed
the
kimdv/add-correct-diagnostic-for-set-modifier-in-variable
branch
2 times, most recently
from
bfc6880 to
546e53e
Compare
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 10, 2023
…n the source code This was motiviated by the following discussion, where the issue becomes more apparent: swiftlang#1643 (comment).
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 10, 2023
…n the source code This was motiviated by the following discussion, where the issue becomes more apparent: swiftlang#1643 (comment).
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 10, 2023
…n the source code This was motiviated by the following discussion, where the issue becomes more apparent: swiftlang#1643 (comment).
ahoppen
reviewed
May 10, 2023
kimdv
force-pushed
the
kimdv/add-correct-diagnostic-for-set-modifier-in-variable
branch
2 times, most recently
from
411aa56 to
1b0a6b3
Compare
ahoppen
approved these changes
May 17, 2023
kimdv
force-pushed
the
kimdv/add-correct-diagnostic-for-set-modifier-in-variable
branch
from
1b0a6b3 to
6a006e2
Compare
Contributor
Author
|
@swift-ci please test |
kimdv
deleted the
kimdv/add-correct-diagnostic-for-set-modifier-in-variable
branch
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
May 25, 2023
…n the source code This was motiviated by the following discussion, where the issue becomes more apparent: swiftlang#1643 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.