tests: End to end tests still require host toolchains #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end to end tests still assume that the host toolchain will be embedded in the SDK. There is currently no provision in the test harness for installing a toolchain before running the tests, so for now we must use the --host-toolchain flag when building SDKs.
Contributor
Author
|
@swift-ci test |
MaxDesiatov
approved these changes
Jan 24, 2025
Contributor
Author
|
I'm looking into working around this problem, but for now the best way to get the E2E tests running is to use embedded host toolchains. Ideally we would be able to unpack a toolchain and use it without having to install it. I've done some experiments in the past which showed that using a single instance of the toolchain made the E2E tests quite a lot quicker on macOS because it avoided repeated XProtect checks on the same toolchain files in different SDKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end to end tests still assume that the host toolchain will be
embedded in the SDK. There is currently no provision in the test
harness for installing a toolchain before running the tests, so for
now we must use the --host-toolchain flag when building SDKs.