generator: Sort keys in JSON metadata files #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to compare generated SDKs using recursive diff, without having to account for spurious differences cause by the order of keys in JSON metadata files.
euanh
added
enhancement
Contributor
Author
|
@swift-ci test |
euanh
added a commit
to euanh/swift-sdk-generator
that referenced
this pull request
Jan 24, 2025
There are now many alternative container runtimes. These often expose a socket interface which is compatible with the `docker` CLI, but may also have their own command line utilities. For our limited requirements, these alternative CLIs are often compatible enough with the `docker` CLI that we can use them directly. This PR adds an environment variable to allow users running alternative container runtimes to use their CLIs directly when building SDKs, removing the need to have the `docker` CLI tools installed as well. I've tested the generator with `podman`; it produced identical SDKs to the current implementation (swiftlang#171), with good performance. The `docker` CLI is currently still required to run the SDK generator tests.
euanh
added a commit
that referenced
this pull request
Jan 24, 2025
#172) There are now many alternative container runtimes. These often expose a socket interface which is compatible with the `docker` CLI, but may also have their own command line utilities. For our limited requirements, these alternative CLIs are often compatible enough with the `docker` CLI that we can use them directly. This PR adds an environment variable to allow users running alternative container runtimes to use their CLIs directly when building SDKs, removing the need to have the `docker` CLI tools installed as well. I've tested the generator with `podman`; it produced identical SDKs to the current implementation (#171), with good performance. The `docker` CLI is currently still required to run the SDK generator tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to compare generated SDKs using recursive diff, without having to account for spurious differences cause by the order of keys in JSON metadata files.