Tests: Migrate MiscellaneousTest to Swift Testing and augment #9039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment
branch
2 times, most recently
from
984eb73 to
39ef641
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment
branch
from
39ef641 to
d08378d
Compare
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment
branch
3 times, most recently
from
d35af32 to
f94d37b
Compare
|
@swift-ci test self hosted |
1 task
|
@swift-ci test self hosted windows |
| ) throws -> [String] { | ||
| let suffix: String | ||
|
|
||
| #if os(Linux) |
There was a problem hiding this comment.
I know this is based on existing code, but you really want to avoid ifdefs in build system code as much as possible in order to avoid unintentionally breaking cross-compilation scenarios -- this depends on the build target, not the host OS. I'd suggest adding a helper method which deduces this suffix from the triple, then use that here.
Migrate the `MiscellaneousTests` suite to Swift Testing and augment the test to run against both the Native and SwiftBuild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9013 Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_MiscellaneousTests_to_ST_and_augment
branch
from
f94d37b to
bf196a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
MiscellaneousTestssuite to Swift Testing and augment the test to run against both the Native and SwiftBuild build system, in addition to thedebugandreleasebuild configurations.Depends on: #9013
Relates to: #8997
issue: rdar://157669245