Skip to content

NFC: Fix @Sendable @escaping order, symbol name typo #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

NFC: Fix @Sendable @escaping order, symbol name typo #7446

merged 1 commit into from
Apr 9, 2024

Conversation

MaxDesiatov
Copy link
Contributor

Sticking to @escaping @Sendable as a preferred order of attributes.

Also fixed dependecies -> dependencies typo.

@MaxDesiatov
Fix @Sendable @escaping order, symbol name typo
46f6d86 
Sticking to `@escaping @Sendable` as a preferred order of attributes.

Also fixed `dependecies` -> `dependencies` typo.
@MaxDesiatov MaxDesiatov added the no functional change No user-visible functional changes included label Apr 9, 2024
@MaxDesiatov MaxDesiatov requested a review from xedin April 9, 2024 17:35
@MaxDesiatov MaxDesiatov self-assigned this Apr 9, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 9, 2024 17:35
xedin
xedin approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov merged commit 72b8498 into main Apr 9, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/fix-attributes-order-typo branch April 9, 2024 20:12
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
@MaxDesiatov @furby-tm
NFC: Fix @Sendable @escaping order, symbol name typo (swiftlang#7446)
5b3ed28 
Sticking to `@escaping @Sendable` as a preferred order of attributes.

Also fixed `dependecies` -> `dependencies` typo.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
@MaxDesiatov @furby-tm
NFC: Fix @Sendable @escaping order, symbol name typo (swiftlang#7446)
abbed9f 
Sticking to `@escaping @Sendable` as a preferred order of attributes.

Also fixed `dependecies` -> `dependencies` typo.
bnbarham pushed a commit to bnbarham/swift-package-manager that referenced this pull request May 18, 2024
@MaxDesiatov @bnbarham
NFC: Fix @Sendable @escaping order, symbol name typo (swiftlang#7446)
14fc141 
Sticking to `@escaping @Sendable` as a preferred order of attributes.

Also fixed `dependecies` -> `dependencies` typo.

(cherry picked from commit 72b8498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@tomerd tomerd Awaiting requested review from tomerd

Assignees

@MaxDesiatov MaxDesiatov

Labels
no functional change No user-visible functional changes included
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @xedin