Automatically enable swift-testing support in swift test when it's a dependency.
#7220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a dependency. This PR causes `swift test` to check the dependencies of the package under test; if they include an explicit reference to the public swift-testing repository on GitHub, then `--enable-experimental-swift-testing` is assumed. A developer can still opt out by explicitly writing `--disable-experimental-swift-testing`. Resolves rdar://99155992.
grynspan
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
neonichu
reviewed
Jan 2, 2024
|
@swift-ci please test |
neonichu
approved these changes
Jan 3, 2024
|
@swift-ci please test windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
deleted the
jgrynspan/99155992-automatically-enable-swift-testing-when-present
branch
grynspan
added a commit
that referenced
this pull request
Jan 8, 2024
Follow-up to #7220. swift-testing itself should get swift-testing support enabled by default, but it doesn't list itself as a dependency. This change extends the code in that PR to also check the identities of the packages being built (rather than just their dependencies.) If the package being built is named "swift-testing", then support is enabled.
grynspan
added a commit
that referenced
this pull request
Jan 9, 2024
#7235) Follow-up to #7220. swift-testing itself should get swift-testing support enabled by default, but it doesn't list itself as a dependency. This change extends the code in that PR to also check the identities of the packages being built (rather than just their dependencies.) If the package being built is named "swift-testing", then support is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes
swift testto check the dependencies of the package under test; if they include an explicit reference to the public swift-testing repository on GitHub, then--enable-experimental-swift-testingis assumed. A developer can still opt out by explicitly writing--disable-experimental-swift-testing.Resolves rdar://99155992.