Skip to content

Avoid use of temp_await in PackageRegistryToolTests.swift #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2023
Merged

Avoid use of temp_await in PackageRegistryToolTests.swift #7015

merged 2 commits into from
Dec 7, 2023

Conversation

MaxDesiatov
Copy link
Contributor

Follow up to #7009, which provides the detailed motivation: we should avoid temp_await as it can lead to deadlocks when combined with Swift Concurrency.

@MaxDesiatov
Avoid use of temp_await in PackageRegistryToolTests.swift
3473fd3 
Follow up to #7009, which provides the detailed motivation: we should avoid `temp_await` as it can lead to deadlocks when combined with Swift Concurrency.
@MaxDesiatov MaxDesiatov added the test suite improvements to SwiftPM test suite label Oct 17, 2023
@MaxDesiatov MaxDesiatov requested a review from yim-lee October 17, 2023 15:14
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov self-assigned this Oct 17, 2023
yim-lee
yim-lee approved these changes Oct 17, 2023
View reviewed changes
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov added the next waiting for next merge window label Oct 19, 2023
@MaxDesiatov MaxDesiatov removed the next waiting for next merge window label Nov 28, 2023
@MaxDesiatov MaxDesiatov merged commit b29c93e into main Dec 7, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/async-archiver branch December 7, 2023 21:39
@neonichu neonichu mentioned this pull request Dec 7, 2023
Merged
neonichu added a commit that referenced this pull request Dec 8, 2023
@neonichu
Revert "Avoid use of temp_await in PackageRegistryToolTests.swift (…
6be9cd8 
…#7015)"

This reverts commit b29c93e.
@neonichu neonichu mentioned this pull request Dec 8, 2023
Merged
kavon pushed a commit that referenced this pull request Dec 8, 2023
@neonichu
Revert "Avoid use of temp_await in PackageRegistryToolTests.swift" (
1eb64ab 
#7169)

Reverts #7015
@MaxDesiatov MaxDesiatov mentioned this pull request Dec 11, 2023
Merged
MaxDesiatov added a commit that referenced this pull request Dec 12, 2023
@MaxDesiatov
Re-revert "Avoid use of temp_await in `PackageRegistryToolTests.swift…
79b7069 
…`" (#7176)

This reverts #7169
with build issues fixed, which itself was a revert of
#7015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu Awaiting requested review from neonichu

@tomerd tomerd Awaiting requested review from tomerd

1 more reviewer

@yim-lee yim-lee yim-lee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MaxDesiatov MaxDesiatov

Labels
concurrency test suite improvements to SwiftPM test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @yim-lee