Skip to content

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Sep 29, 2023

motivation: better performance for operations that load manifest often

changes:

  • add in-memory cache in ManifesLoader
  • only cache JSON parser results and add package location to the cache key to address potential issues such as rdar://73462555 which made us remove such cache in the past
  • add test

rdar://73521470
rdar://111346666

motivation: better performance for operations that load manifest often

changes:
* add in-memory cache in ManifesLoader
* only cache JSON parser results and add package location to the cache key to address potential issues such as rdar://73462555 which made us remove such cache in the past
* add test

rdar://73521470
@tomerd
Copy link
Contributor Author

tomerd commented Sep 29, 2023

@swift-ci smoke test

@tomerd
Copy link
Contributor Author

tomerd commented Sep 29, 2023

@swift-ci test

@neonichu
Copy link
Contributor

[1602/1602] Testing CommandsTests.TestToolTests/testSwiftTestSkip
Test Suite 'Selected tests' started at 2023-09-29 05:57:49.681Test Suite 'SwiftPMPackageTests.xctest' started at 2023-09-29 05:57:49.683Test Suite 'PackageDescription4_2LoadingTests' started at 2023-09-29 05:57:49.683Test Case '-[PackageLoadingTests.PackageDescription4_2LoadingTests testCaching]' started./Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/Tests/PackageLoadingTests/PD_4_2_LoadingTests.swift:682: error: -[PackageLoadingTests.PackageDescription4_2LoadingTests testCaching] : XCTAssertEqual failed: threw error "timeout waiting for parsing"Test Case '-[PackageLoadingTests.PackageDescription4_2LoadingTests testCaching]' failed (8.120 seconds).Test Suite 'PackageDescription4_2LoadingTests' failed at 2023-09-29 05:57:57.803.
	 Executed 1 test, with 1 failure (1 unexpected) in 8.120 (8.120) secondsTest Suite 'SwiftPMPackageTests.xctest' failed at 2023-09-29 05:57:57.803.
	 Execut

Probably related to the changes?

@tomerd
Copy link
Contributor Author

tomerd commented Sep 29, 2023

@swift-ci test

@tomerd
Copy link
Contributor Author

tomerd commented Sep 29, 2023

for reference, brings back #3222

@tomerd tomerd enabled auto-merge (squash) September 29, 2023 20:10
@tomerd
Copy link
Contributor Author

tomerd commented Sep 30, 2023

@swift-ci test windows

@tomerd tomerd merged commit 76133fd into swiftlang:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants