[5.10] Add and fix missing Triple tests
#6932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
changed the title
MaxDesiatov
commented
Sep 20, 2023
| @@ -239,53 +239,6 @@ extension Triple { | |||
| } | |||
| } | |||
|
|
|||
| // The Darwin platform version used for linking. | |||
| public var darwinLinkerPlatformVersion: Version { | |||
There was a problem hiding this comment.
Removed as unused, previously it was incorrectly used as a substitute for nil where Triple.Version should've been optional in the first place.
|
@swift-ci test |
MaxDesiatov
changed the title
Triple tests
|
Failure looks real |
(cherry picked from commit 8de70d3) # Conflicts: # Tests/BasicsTests/TripleTests.swift
MaxDesiatov
force-pushed
the
maxd/fix-triple-soundness-5.10
branch
from
469e858 to
f73e80f
Compare
|
@swift-ci test |
|
@swift-ci test |
neonichu
approved these changes
Sep 20, 2023
|
@swift-ci test windows |
MaxDesiatov
added a commit
that referenced
this pull request
Sep 28, 2023
Cherry-pick of #6843 Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after `TSC.Triple` type was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check. (cherry picked from commit 8de70d3) ``` # Conflicts: # Tests/BasicsTests/TripleTests.swift ``` Related to rdar://113967401 Maybe related to rdar://115731621
MaxDesiatov
added a commit
that referenced
this pull request
Sep 28, 2023
Cherry-pick of #6843 Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after `TSC.Triple` type was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check. (cherry picked from commit 8de70d3) ``` # Conflicts: # Tests/BasicsTests/TripleTests.swift ``` Related to rdar://113967401 Maybe related to rdar://115731621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6843
Vendored Swift Driver triple was not checked against a few tests that weren't brought over from TSC after
TSC.Tripletype was deprecated. We should fix those tests, especially as they verified that per-component equality for triples worked instead of the current string-based equality check.(cherry picked from commit 8de70d3)
Related to rdar://113967401
May be related to rdar://115731621