Add logging to KeychainAuthorizationProvider #6737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
tomerd
approved these changes
Jul 20, 2023
|
@swift-ci please test Windows platform |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Jul 21, 2023
yim-lee
added a commit
that referenced
this pull request
Jul 21, 2023
) * Add logging to KeychainAuthorizationProvider (#6737) * Keychain credentials - better support for protocol and port Motivation: `KeychainAuthorizationProvider` supports HTTPS only and no port. Credentials for URLs that include port or HTTP URLs stored in Keychain are not found. Changes: - Support HTTP - Use URL port as search criteria * Fix test compilation error on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.