Skip to content

Work around change in integer literal inference #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Work around change in integer literal inference #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6416295
Work around change in integer literal inference
natecook1000 Jan 7, 2025
cf07fcd
Fix availability for capture tests
natecook1000 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/Exercises/Participants/HandWrittenParticipant.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ private func graphemeBreakPropertyData(
}

// For testing our framework
if forceFailure, lower == Unicode.Scalar(0x07FD) {
let failureSigil = Unicode.Scalar(0x07FD as UInt32)!
if forceFailure, lower == failureSigil {
return nil
}

Expand Down
2 changes: 2 additions & 0 deletions Sources/_StringProcessing/Regex/Match.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ extension Regex.Match {
from: anyRegexOutput.input
)
guard let output = typeErasedMatch as? Output else {
print(typeErasedMatch)
print(Output.self)
fatalError("Internal error: existential cast failed")
}
return output
Expand Down
13 changes: 6 additions & 7 deletions Tests/RegexBuilderTests/RegexDSLTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1845,8 +1845,8 @@ extension RegexDSLTests {
}

func testLabeledCaptures_labeledCapture() throws {
guard #available(macOS 13, *) else {
throw XCTSkip("Fix only exists on macOS 13")
guard #available(macOS 14.0, *) else {
throw XCTSkip("Fix only exists on macOS 14")
}
// The output type of a regex with a labeled capture is dropped.
let dslWithLabeledCapture = Regex {
Expand Down Expand Up @@ -1884,8 +1884,8 @@ extension RegexDSLTests {
}

func testLabeledCaptures_bothCapture() throws {
guard #available(macOS 13, *) else {
throw XCTSkip("Fix only exists on macOS 13")
guard #available(macOS 14.0, *) else {
throw XCTSkip("Fix only exists on macOS 14")
}
// Only the output type of a regex with a labeled capture is dropped,
// outputs of other regexes in the same DSL are concatenated.
Expand All @@ -1910,9 +1910,8 @@ extension RegexDSLTests {
}

func testLabeledCaptures_tooManyCapture() throws {
return
guard #available(macOS 13, *) else {
throw XCTSkip("Fix only exists on macOS 13")
guard #available(macOS 14.0, *) else {
throw XCTSkip("Fix only exists on macOS 14")
}
// The output type of a regex with too many captures is dropped.
// "Too many" means the left and right output types would add up to >= 10.
Expand Down