Add @MainActor to waitForExpectations(timeout:handler:) #428 #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
dennisweissmann
approved these changes
Jun 25, 2023
|
@swift-ci please test Windows |
|
@swift-ci please clean test Windows |
|
@swift-ci please test |
compnerd
approved these changes
Jun 25, 2023
|
@swift-ci please test |
|
@swift-ci please clean test Windows |
briancroom
approved these changes
Jun 26, 2023
XCTest.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/waitForExpectations-should-be-main-actor-isolated
branch
2 times, most recently
from
7d8152e to
0afda42
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
force-pushed
the
jgrynspan/waitForExpectations-should-be-main-actor-isolated
branch
from
0afda42 to
5607291
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please clean test Windows |
|
Compiler crash happened again, so I'm just going to comment out the new pro forma unit tests for now. |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Windows |
1 similar comment
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
added a commit
that referenced
this pull request
Jun 28, 2023
…ld-be-main-actor-isolated Add @mainactor to waitForExpectations(timeout:handler:) #428
compnerd
deleted the
jgrynspan/waitForExpectations-should-be-main-actor-isolated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
waitForExpectations()as main-actor-isolated, as it is in Xcode's version of XCTest. It is marked@preconcurrency @MainActorso that existing synchronous functions can continue to use it withoutawaitor@MainActor.Resolves #428.