Remove errant test #2291
Merged
Remove errant test #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Member
Author
|
@swift-ci Please test |
ahoppen
approved these changes
Sep 13, 2025
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Hmm, unfortunate that we no longer report whitespace-only changes but fair enough. Maybe if we changed the test to have a little more real text than A would we get back to the whitespace-only changes. I’ll investigate once your collection diffing algorithm changes are in.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Oct 8, 2025
… produced Change the test case to something a little more realistic than lines containing A, B, and C. Then add the check again that all changes reported are whitespaces, which was remvoed by swiftlang#2291.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a difference in algorithms, the linear-space
CollectionDifferencealgorithm includes some non-whitespace changes for this test example.The current algorithm only identifies whitespace as differences, but the updated algorithm includes both a removal and insertion of the "A" character here: https://github.com/natecook1000/sourcekit-lsp/blob/46c99dabc4acf116a572fd58ae162a83b61e6cec/Tests/SourceKitLSPTests/FormattingTests.swift#L266