-
Notifications
You must be signed in to change notification settings - Fork 138
Add support for request body to be larger than 2GB on 32-bit devices #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-server-bot test this please |
fabianfett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks very god! Great patch! @Lukasa can you please check the API changes?
…d Atomics with NIOLock in RequestBagTests. Fixed test cases.
|
@swift-server-bot add to allowlist |
…e path in a URL instance created from a relative URL.
… from the path in a URL instance created from a relative URL." This reverts commit 330117f.
fabianfett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Motivation:
Int.Int32.max, these properties overflow and cause a crash.Int64type.Modifications:
knownfield of theRequestBodyLengthenum toInt64.expectedBodyLengthandsentBodyBytesinHTTPRequestStateMachinetoInt64?andInt64respectively.public var length: Int?property ofHTTPClient.Bodyand backed it with a new property:contentLength: Int64?streamfunction inHTTPClient.Bodyto work with the newcontentLengthproperty.streamfunction has different parameter names (length->contentLengthandstream->bodyStream) to avoid ambiguity problems.Int32.Result: