Skip to content

Typo: Replace HTTPExecutingRequest with HTTPExecutableRequest #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Typo: Replace HTTPExecutingRequest with HTTPExecutableRequest #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2ClientRequestHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ final class HTTP2ClientRequestHandler: ChannelDuplexHandler {

private func writeRequestBodyPart0(_ data: IOData, request: HTTPExecutableRequest) {
guard self.request === request, let context = self.channelContext else {
// Because the HTTPExecutingRequest may run in a different thread to our eventLoop,
// calls from the HTTPExecutingRequest to our ChannelHandler may arrive here after
// Because the HTTPExecutableRequest may run in a different thread to our eventLoop,
// calls from the HTTPExecutableRequest to our ChannelHandler may arrive here after
// the request has been popped by the state machine or the ChannelHandler has been
// removed from the Channel pipeline. This is a normal threading issue, noone has
// screwed up.
Expand Down