[HTTP1Connection] Add download streaming backpressure test #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-integration-test-download-streaming
branch
2 times, most recently
from
db307a2 to
bc95874
Compare
fabianfett
force-pushed
the
ff-integration-test-download-streaming
branch
from
bc95874 to
4653c80
Compare
Member
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #427 we want to switch the implementation over to our new
HTTPConnectionPool. When we do this, we want to remove the possibility to access the underlying channel. For this reason we need to remove a number of tests fromHTTPClientInternalTests. As @weissi pointed out, we should at least still integration test downstream backpressure.This pr replicates the behavior from
HTTPClientInternalTests.testUploadStreamingBackpressuredirectly on theHTTP1Connection.Changes
HTTPClientInternalTests.testUploadStreamingBackpressuretestDownloadStreamingBackpressuresince we only test incoming bytes backpressure.Result
An integration backpressure test, that survives #427.