Skip to content

Add new HTTPConnectionPool #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add new HTTPConnectionPool #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e4093c
Add HTTPConnectionPool
fabianfett Sep 9, 2021
ff70dd2
Code review
fabianfett Sep 9, 2021
a3a844e
Code review
fabianfett Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/AsyncHTTPClient/ConnectionPool/HTTP1.1/HTTP1Connection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,14 @@ final class HTTP1Connection {
self.channel.triggerUserOutboundEvent(HTTPConnectionEvent.shutdownRequested, promise: nil)
}

func close(promise: EventLoopPromise<Void>?) {
return self.channel.close(mode: .all, promise: promise)
}

func close() -> EventLoopFuture<Void> {
return self.channel.close()
let promise = self.channel.eventLoop.makePromise(of: Void.self)
self.close(promise: promise)
return promise.futureResult
}

func taskCompleted() {
Expand Down
8 changes: 7 additions & 1 deletion Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2Connection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,14 @@ final class HTTP2Connection {
}
}

func close(promise: EventLoopPromise<Void>?) {
return self.channel.close(mode: .all, promise: promise)
}

func close() -> EventLoopFuture<Void> {
self.channel.close()
let promise = self.channel.eventLoop.makePromise(of: Void.self)
self.close(promise: promise)
return promise.futureResult
}

private func start() -> EventLoopFuture<Void> {
Expand Down
Loading