Implement SOCKS proxy functionality #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jun 16, 2021
fabianfett
reviewed
Jun 16, 2021
fabianfett
reviewed
Jun 16, 2021
fabianfett
reviewed
Jun 16, 2021
Lukasa
requested changes
Jun 17, 2021
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Cool, looking good! Some notes in the diff.
Collaborator
Author
|
@swift-server-bot test this please |
Lukasa
reviewed
Jun 17, 2021
Co-authored-by: Cory Benfield <[email protected]>
…ent into de/socks-client
PeterAdams-A
approved these changes
Jun 18, 2021
Collaborator
PeterAdams-A
left a comment
PeterAdams-A
left a comment
There was a problem hiding this comment.
A few minor comments but looks generally OK to me.
fabianfett
reviewed
Jun 18, 2021
fabianfett
reviewed
Jun 18, 2021
Comment on lines
+345
to
+346
| public struct Authorization: Hashable { | ||
| private enum Scheme: Hashable { |
Collaborator
There was a problem hiding this comment.
Getting equatable conformance on the internal Proxy Type enum.
fabianfett
reviewed
Jun 18, 2021
Lukasa
reviewed
Jun 18, 2021
Lukasa
requested changes
Jun 18, 2021
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Cool, a few cleanups needed here.
Lukasa
approved these changes
Jun 18, 2021
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Ok, this LGTM. Let's get a swift-nio-extras release out the door and we can move forward here.
Collaborator
Author
|
@swift-server-bot test this please |
Lukasa
reviewed
Jun 18, 2021
fabianfett
reviewed
Jun 18, 2021
| import NIOFoundationCompat | ||
| import NIOHTTP1 | ||
| import NIOHTTPCompression | ||
| import NIOSOCKS |
Member
There was a problem hiding this comment.
I don't think we need this here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Proxy type to enable a
HTTPClientto send requests via a SOCKSv5 Proxy server.