Skip to content

chore: untrack keyed validation logic #9618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore: untrack keyed validation logic #9618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1780811
untrack validation logic
trueadm Nov 23, 2023
344784a
chore: untrack keyed validation logic
trueadm Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-schools-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: untrack keyed validation logic
3 changes: 2 additions & 1 deletion packages/svelte/src/internal/client/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { untrack } from './runtime.js';
import { is_array } from './utils.js';

/** regex of all html void element names */
Expand Down Expand Up @@ -69,7 +70,7 @@ export function validate_dynamic_element_tag(tag_fn) {
*/
export function validate_each_keys(collection, key_fn) {
const keys = new Map();
const maybe_array = collection();
const maybe_array = untrack(() => collection());
const array = is_array(maybe_array)
? maybe_array
: maybe_array == null
Expand Down