-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: expose event for navigation handler when navigation is popstate or link #14307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3b65197 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm wondering if it's worth exposing the entire event object instead of an individual property here. This would help us avoid this issue again if a new property is added. |
yeah we definitely shouldn't just add |
@eltigerchino It seems more reasonable, so I've updated PR to expose entire event object. |
Thank you. I think this is closer but still not quite ready to merge:
|
|
Export event object of
PopStateEvent
into navigation handler callback if navigation ispopstate
.Closes #13169.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits