Skip to content

feat: added the prefer-svelte-reactivity rule #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

feat: added the prefer-svelte-reactivity rule #1151

merged 3 commits into from
Jul 16, 2025
+1,363 −0

Conversation

@marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Mar 24, 2025 •
edited
Loading

Closes #1071

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0996bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from d061a99 to 6999c90 Compare March 24, 2025 09:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@0996bb0

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 5cede00 to f44a65c Compare March 24, 2025 09:25
baseballyama
baseballyama reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add tests for .svelte.js files also.

@marekdedic
Copy link
Contributor Author

marekdedic commented Mar 24, 2025

I think we need to add tests for .svelte.js files also.

Yes, I wanted to ask about whether that's something we're set up to do, I couldn't find any such tests on the repo...

@marekdedic
Copy link
Contributor Author

marekdedic commented Mar 24, 2025

@ota-meshi Can you please take a look at the test file? I tried the solution from eslint-community/eslint-utils#249 (comment), but it didn't work for me :/

@ota-meshi
Copy link
Member

ota-meshi commented Apr 30, 2025

@marekdedic What have you tried? Have you added URL here?

eslint-plugin-svelte/packages/eslint-plugin-svelte/tests/utils/utils.ts

Line 18 in 3ddbd83

const globals = {

@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from 7603712 to d1230de Compare May 3, 2025 10:11
@marekdedic
Copy link
Contributor Author

marekdedic commented May 3, 2025

@marekdedic What have you tried? Have you added URL here?

That's exactly what I tried, but it didn't work :(

@ota-meshi
Copy link
Member

ota-meshi commented May 8, 2025 •
edited
Loading

Is it url01-input.svelte that you're saying didn't work? I've tried adding URL: 'readonly', URLSearchParams: 'readonly' to globals in your repository and it seems to work fine.

image

@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch 6 times, most recently from 18dad7e to dcf3e34 Compare May 8, 2025 14:09
@marekdedic
Copy link
Contributor Author

marekdedic commented May 8, 2025

Ok, I was adding it in a different place and the value got overriden, thanks :)

@marekdedic marekdedic marked this pull request as ready for review May 8, 2025 14:13
@marekdedic marekdedic requested a review from baseballyama May 8, 2025 14:13
ota-meshi
ota-meshi reviewed May 8, 2025
View reviewed changes
@ota-meshi ota-meshi mentioned this pull request May 8, 2025
Merged
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from dcf3e34 to 1319f62 Compare May 12, 2025 15:59
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 30e17ee to 8e74c27 Compare May 28, 2025 16:00
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 169791a to af1cb8f Compare June 7, 2025 08:32
ota-meshi
ota-meshi reviewed Jun 7, 2025
View reviewed changes
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from af1cb8f to 1689df3 Compare June 7, 2025 15:07
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch 9 times, most recently from 23c8253 to 586dca9 Compare June 9, 2025 15:36
@marekdedic marekdedic requested a review from ota-meshi June 9, 2025 15:41
@marekdedic
Copy link
Contributor Author

marekdedic commented Jun 9, 2025

I have re-implemented the PR so that it checks all the property calls and only reports if the variable is mutated.

@marekdedic marekdedic mentioned this pull request Jun 9, 2025
Merged
ota-meshi
ota-meshi requested changes Jun 9, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks almost good to me, but I have two comments.

@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from 586dca9 to 064f100 Compare June 10, 2025 16:25
@marekdedic marekdedic force-pushed the prefer-svelte-reactivity branch from 064f100 to 0996bb0 Compare June 10, 2025 16:39
@marekdedic marekdedic requested a review from ota-meshi June 10, 2025 16:43
ota-meshi
ota-meshi approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi
Copy link
Member

ota-meshi commented Jun 11, 2025

@baseballyama Just to be sure, could you please check this PR?
This is a new rule that is included in the recommended config.

@baseballyama
Copy link
Member

baseballyama commented Jun 11, 2025

I will review it within a few days.👍

@marekdedic
Copy link
Contributor Author

marekdedic commented Jul 1, 2025

@baseballyama Gentle reminder :)

baseballyama
baseballyama approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review!

@baseballyama baseballyama merged commit 843730d into sveltejs:main Jul 16, 2025
17 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Merged
@marekdedic marekdedic deleted the prefer-svelte-reactivity branch July 16, 2025 15:53
@marekdedic
Copy link
Contributor Author

marekdedic commented Jul 16, 2025

No worries, I presume you also do this in your free time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@baseballyama baseballyama baseballyama approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add rule prefer-svelte-reactivity

3 participants

@marekdedic @ota-meshi @baseballyama