This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Fix bad typing on upload functions #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anand2312
reviewed
Apr 23, 2023
storage3/_async/file_api.py
Outdated
| extra_headers = {"Content-Type": "application/json"} | ||
| body = {**DEFAULT_SEARCH_OPTIONS, **extra_options, "prefix": path or ""} | ||
| body = {**DEFAULT_SEARCH_OPTIONS, ** | ||
| extra_options, "prefix": path or ""} |
There was a problem hiding this comment.
Why the odd line-splits? It looked better before I think 😅
|
Tests are failing because of the odd style changes introduced in this PR that Black (the code formatter) doesn't like. Please run Black on the changed files. |
|
Done! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It simply update the function prototype of
uploadto type correctly the file argumentWhat is the current behavior?
The upload function implements the management of Bytes/IO-like buffers, but the types of the functions doesn't allow their use.